Skip to content

Fix(test): resolve data race in StreamedRequest #1727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2025
Merged

Fix(test): resolve data race in StreamedRequest #1727

merged 1 commit into from
Oct 15, 2025
+32 −18

Conversation

LukeAVanDrie
Copy link
Contributor

What type of PR is this?

/kind test
/kind flake

What this PR does / why we need it:

This PR fixes a data race in the StreamedRequest integration test utility function. The race occurred due to unsynchronized access to a boolean flag used for timeout handling between the main test goroutine and a timer goroutine.

The fix replaces the boolean flag and timer goroutine with a channel and select statement. This ensures that communication between the goroutines is safe and prevents the data race, making the test suite more stable.

Which issue(s) this PR fixes:

Fixes #1718

Does this PR introduce a user-facing change?:

NONE

@LukeAVanDrie
Fix(test): resolve data race in StreamedRequest
1dce68e 
Replaces the boolean flag and timer goroutine with a channel and select
statement to prevent a data race on the timeout in integration tests.
This ensures safe concurrent access when handling test timeouts.
@k8s-ci-robot
Copy link
Contributor

@LukeAVanDrie: The label(s) kind/test cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind test
/kind flake

What this PR does / why we need it:

This PR fixes a data race in the StreamedRequest integration test utility function. The race occurred due to unsynchronized access to a boolean flag used for timeout handling between the main test goroutine and a timer goroutine.

The fix replaces the boolean flag and timer goroutine with a channel and select statement. This ensures that communication between the goroutines is safe and prevents the data race, making the test suite more stable.

Which issue(s) this PR fixes:

Fixes #1718

Does this PR introduce a user-facing change?:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the kind/flake Categorizes issue or PR as related to a flaky test. label Oct 14, 2025
@netlify Netlify
Copy link

netlify bot commented Oct 14, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 1dce68e
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68eee2ce8801a600082c7a61
😎 Deploy Preview https://deploy-preview-1727--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 14, 2025
@k8s-ci-robot k8s-ci-robot requested review from ahg-g and elevran October 14, 2025 23:54
@k8s-ci-robot
Copy link
Contributor

Hi @LukeAVanDrie. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 14, 2025
@LukeAVanDrie
Copy link
Contributor Author

@ahg-g I actually just pulled in the relevant fix from my open hermetic testing refactoring PR #1627 as that is still blocked on some other RCA work.

@kfswain
Copy link
Collaborator

kfswain commented Oct 15, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 15, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Oct 15, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, LukeAVanDrie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2025
@k8s-ci-robot k8s-ci-robot merged commit 082e720 into kubernetes-sigs:main Oct 15, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahg-g ahg-g Awaiting requested review from ahg-g

@elevran elevran Awaiting requested review from elevran

Assignees

@ahg-g ahg-g

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

EPP hermetic tests flake with --race flag.

4 participants

@LukeAVanDrie @k8s-ci-robot @kfswain @ahg-g